Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COEP HTTP - works with CORS and CORP - but separately #37343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Dec 23, 2024

Fixes #36503

In addition this is a significant rework of the COEP header because I found it confusing.
The main problem I have with the existing doc is that it mixes up the effects and "nature" of CORS and CORP and the effect of this header when using these two.

Using the example of an <img> it is important to remember that a cross-origin fetch is allowed by default - if your HTML doesn't include crossorigin attribute the image is fetched in no-cors mode and will be returned by default and included unless the resource has CORP set on it.
However if you set the crossorigin attribute the request is not-no-cors - it might be a cors mode request and could have different settings for things like whether credentials are included.

So it isn't just you must set CORs or CORP, it depends on how you make the request. I have tried to draw that distinction.

PS. The bug was about navigation requests. I dont think they are relevant, because a navigation is not embedding a resource. Though I guess the fetch of a new content for a frame would count, and that would be handled as per usual for CORs (whatever that is).

@github-actions github-actions bot added Content:HTTP HTTP docs size/s [PR only] 6-50 LoC changed labels Dec 23, 2024
@@ -31,12 +31,24 @@ Cross-Origin-Embedder-Policy: unsafe-none | require-corp | credentialless
### Directives

- `unsafe-none`
- : This is the default value. Allows the document to fetch cross-origin resources without giving explicit permission through the CORS protocol or the {{HTTPHeader("Cross-Origin-Resource-Policy")}} header.
- : Allows the document to load cross-origin resources without giving explicit permission through the CORS protocol or the {{HTTPHeader("Cross-Origin-Resource-Policy")}} header.
Copy link
Collaborator Author

@hamishwillee hamishwillee Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if CORP is same-origin - i.e. the unsafe-none would allow loading if CORP isn't set, but will the browser allow this if CORP explicitly says it does NOT want to be loaded?

I'm having trouble working it out from the spec.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read and re-read this and checked some explainers and this is my understanding:

  • You can set CORP on any individual resource (regardless of COEP) and CORP will be respected -> explicitly setting COEP 'unsafe-none' doesn't interfere with CORP.
  • If you set COEP require-corp, then all resources (descendents) must have a CORP / CORS policy.

It boils down to scope, so a resource can have a CORP / CORS that controls where it's embedded, then a document sets COEP, and all embedded things have to have CORP or CORS defined.

COEP prevents a document from loading any non-same-origin resources which don't explicitly grant the document permission to be loaded.

https://github.com/ArthurSonzogni/coep-reflection?tab=readme-ov-file#motivating-use-cases

Also we should add these to the See also:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

github-actions bot commented Dec 23, 2024

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/HTTP/Headers/Cross-Origin-Embedder-Policy
Title: Cross-Origin-Embedder-Policy
Flaw count: 1

  • unknown:
    • No generic content config found

(comment last updated: 2025-01-23 23:30:57)

Comment on lines +47 to +48
- : A document can load cross-origin resources that are requested in [`no-cors` mode](/en-US/docs/Web/API/Request/mode) **without** an explicit permission via the {{HTTPHeader("Cross-Origin-Resource-Policy")}} header.
In this case requests are sent without credentials: cookies are omitted in the request, and ignored in the response.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, what if CORP is same-origin - i.e. the unsafe-none would allow loading if CORP isn't set, but will the browser allow this if CORP explicitly says it does NOT want to be loaded?

If you enable COEP using `require-corp` and have a cross origin resource that needs to be loaded, it needs to support [CORS](/en-US/docs/Web/HTTP/CORS) and you need to explicitly mark the resource as loadable from another origin to avoid blockage from COEP. For example, you can use the [`crossorigin`](/en-US/docs/Web/HTML/Attributes/crossorigin) attribute for this image from a third-party site:
If you enable COEP using `require-corp` and want to embed a cross origin resource that supports [CORS](/en-US/docs/Web/HTTP/CORS), you will need to explicitly specify the HTML [`crossorigin`](/en-US/docs/Web/HTML/Attributes/crossorigin) attribute so that it is requested in `cors` mode.

For example, you would you this approach to fetch an image from a third-party site that supports CORS:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, we could do with an equivalent example for CORP.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But not planning on doing now!

If you enable COEP using `require-corp` and have a cross origin resource that needs to be loaded, it needs to support [CORS](/en-US/docs/Web/HTTP/CORS) and you need to explicitly mark the resource as loadable from another origin to avoid blockage from COEP. For example, you can use the [`crossorigin`](/en-US/docs/Web/HTML/Attributes/crossorigin) attribute for this image from a third-party site:
If you enable COEP using `require-corp` and want to embed a cross origin resource that supports [CORS](/en-US/docs/Web/HTTP/CORS), you will need to explicitly specify the HTML [`crossorigin`](/en-US/docs/Web/HTML/Attributes/crossorigin) attribute so that it is requested in `cors` mode.

For example, you would you this approach to fetch an image from a third-party site that supports CORS:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For example, you would you this approach to fetch an image from a third-party site that supports CORS:
For example, you would use this approach to fetch an image from a third-party site that supports CORS:

@@ -68,7 +80,9 @@ if (crossOriginIsolated) {

### Avoiding COEP blockage with CORS

If you enable COEP using `require-corp` and have a cross origin resource that needs to be loaded, it needs to support [CORS](/en-US/docs/Web/HTTP/CORS) and you need to explicitly mark the resource as loadable from another origin to avoid blockage from COEP. For example, you can use the [`crossorigin`](/en-US/docs/Web/HTML/Attributes/crossorigin) attribute for this image from a third-party site:
If you enable COEP using `require-corp` and want to embed a cross origin resource that supports [CORS](/en-US/docs/Web/HTTP/CORS), you will need to explicitly specify the HTML [`crossorigin`](/en-US/docs/Web/HTML/Attributes/crossorigin) attribute so that it is requested in `cors` mode.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not just via HTML, but fetch('https://thing', { mode: 'cors' }) or crossOrigin like https://developer.mozilla.org/en-US/docs/Web/API/HTMLScriptElement/crossOrigin

Cross-origin resource loading will be blocked by COEP unless:

- The resource is requested in `no-cors` mode and the response includes a {{HTTPHeader("Cross-Origin-Resource-Policy")}} header that allows it to be loaded into the document origin.
- The resource is requested in `cors` mode (the HTML [`crossorigin`](/en-US/docs/Web/HTML/Attributes/crossorigin) attribute is set) and the resource supports CORS.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as below, not just HTML, but via fetch mode: cors or crossOrigin in JS.

@wbamberg wbamberg removed their request for review January 22, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

credentialless - explanation of "navigate" requests requiring Cross-Origin-Resource-Policy response header
2 participants